Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize exceptions of arithmetic operations on Datetime-like data #2101

Merged
merged 3 commits into from
Mar 31, 2021

Conversation

xinrong-meng
Copy link
Contributor

@xinrong-meng xinrong-meng commented Mar 11, 2021

Standardize exceptions of arithmetic operations on Datetime-like data

@codecov-io
Copy link

Codecov Report

Merging #2101 (1beaa6f) into master (b413231) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2101      +/-   ##
==========================================
+ Coverage   95.36%   95.39%   +0.02%     
==========================================
  Files          60       60              
  Lines       13625    13669      +44     
==========================================
+ Hits        12994    13040      +46     
+ Misses        631      629       -2     
Impacted Files Coverage Δ
databricks/koalas/base.py 97.01% <100.00%> (+0.11%) ⬆️
databricks/koalas/tests/indexes/test_datetime.py 100.00% <100.00%> (ø)
databricks/koalas/numpy_compat.py 96.87% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b413231...1beaa6f. Read the comment docs.

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ueshin
Copy link
Collaborator

ueshin commented Mar 31, 2021

Thanks! merging.

@ueshin ueshin merged commit fcf21dc into databricks:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants