Check index_dtype and data_dtypes more strictly. #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueshin
changed the title
| else dtype | ||
| for dtype, scol in zip(data_dtypes, data_spark_columns) | ||
| ] | ||
|
|
||
| assert all( | ||
| as_spark_type(dtype, raise_error=False) is not None for dtype in data_dtypes | ||
| isinstance(dtype, Dtype.__args__) # type: ignore |
There was a problem hiding this comment.
Can I take it as pandas dtype consists of np.dtype and ExtensionDtype?
There was a problem hiding this comment.
I believe so, so far. https://github.com/pandas-dev/pandas/blob/7af47c9/pandas/_typing.py#L126
xinrong-meng
approved these changes
Mar 15, 2021
|
Looks great, thank you! |
|
Thanks! merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks explicitly
index_dtypeanddata_dtypesare the instance ofnp.dtypeorExtensionDtype.