-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a basic support for the categorical type. #2064
Conversation
This is based on #2061. |
Codecov Report
@@ Coverage Diff @@
## master #2064 +/- ##
==========================================
- Coverage 95.27% 95.21% -0.06%
==========================================
Files 57 60 +3
Lines 13257 13460 +203
==========================================
+ Hits 12630 12816 +186
- Misses 627 644 +17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine from a cursory look
if len(categories) == 0: | ||
scol = F.lit(-1) | ||
else: | ||
kvs = list( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could think about having a util for this codes ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I'm going to do some refactoring in the next PR.
Thanks! Let me merge this now. Please feel free to leave comments. |
Experimental.
Add a basic support for the categorical type.
Currently type conversion with
astype
from/to the categorical type is supported, and other operations are not supported yet.