-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement (DataFrame|Series).plot.kde with Plotly #2028
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2028 +/- ##
==========================================
- Coverage 94.59% 90.57% -4.03%
==========================================
Files 50 50
Lines 11277 11210 -67
==========================================
- Hits 10668 10153 -515
- Misses 609 1057 +448
Continue to review full report at Codecov.
|
946920e
to
d3b84da
Compare
sample_range = max_val - min_val | ||
ind = np.linspace(min_val - 0.5 * sample_range, max_val + 0.5 * sample_range, 1000,) | ||
elif is_integer(ind): | ||
min_val, max_val = sdf.select(F.min(sdf.columns[-1]), F.max(sdf.columns[-1])).first() | ||
|
||
sample_range = min_val - max_val |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a bug BTW. it had to be max_val - min_val
@staticmethod | ||
def get_ind(sdf, ind): | ||
# 'sdf' is a Spark DataFrame that selects one column. | ||
def calc_min_max(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a logic to get the max/min from multiple columns
2586c0f
to
4e34196
Compare
4e34196
to
7db02e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR implements (DataFrame|Series).plot.kde with Plotly:
Can be tested here:
http://mybinder.org/v2/gh/hyukjinkwon/koalas/plotly-kde?filepath=docs%2Fsource%2Fgetting_started%2F10min.ipynb
matplotlib:
plotly