Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PYARROW_IGNORE_TIMEZONE for binder. #1965

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Dec 11, 2020

We should set PYARROW_IGNORE_TIMEZONE environment variable for binder; otherwise it shows a warning:

Screen Shot 2020-12-10 at 6 26 53 PM

@ueshin ueshin requested a review from itholic December 11, 2020 02:26
@itholic
Copy link
Contributor

itholic commented Dec 11, 2020

LGTM. pending tests

@codecov-io
Copy link

codecov-io commented Dec 11, 2020

Codecov Report

Merging #1965 (fc8ef7a) into master (eefe9b5) will decrease coverage by 0.88%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1965      +/-   ##
==========================================
- Coverage   94.60%   93.71%   -0.89%     
==========================================
  Files          49       49              
  Lines       10890    10890              
==========================================
- Hits        10302    10206      -96     
- Misses        588      684      +96     
Impacted Files Coverage Δ
databricks/koalas/usage_logging/__init__.py 24.78% <0.00%> (-67.53%) ⬇️
databricks/koalas/usage_logging/usage_logger.py 47.82% <0.00%> (-52.18%) ⬇️
databricks/koalas/__init__.py 85.93% <0.00%> (-4.69%) ⬇️
databricks/conftest.py 97.10% <0.00%> (-2.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eefe9b5...fc8ef7a. Read the comment docs.

@HyukjinKwon HyukjinKwon merged commit 485437a into databricks:master Dec 11, 2020
@ueshin ueshin deleted the binder branch December 11, 2020 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants