Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage index spark columns instead of index spark column names. #1944

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Dec 1, 2020

Manages index spark columns instead of index spark column names as the same as data spark columns.

@codecov-io
Copy link

codecov-io commented Dec 1, 2020

Codecov Report

Merging #1944 (5abd90d) into master (809ed86) will increase coverage by 0.34%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1944      +/-   ##
==========================================
+ Coverage   94.16%   94.51%   +0.34%     
==========================================
  Files          41       45       +4     
  Lines       10055    10676     +621     
==========================================
+ Hits         9468    10090     +622     
+ Misses        587      586       -1     
Impacted Files Coverage Δ
databricks/koalas/base.py 96.89% <ø> (ø)
databricks/koalas/utils.py 95.71% <ø> (ø)
databricks/koalas/window.py 95.89% <ø> (ø)
databricks/koalas/namespace.py 84.23% <84.61%> (ø)
databricks/koalas/frame.py 96.66% <97.29%> (-0.01%) ⬇️
databricks/koalas/accessors.py 93.46% <100.00%> (ø)
databricks/koalas/groupby.py 91.42% <100.00%> (ø)
databricks/koalas/indexes.py 96.95% <100.00%> (+0.10%) ⬆️
databricks/koalas/indexing.py 92.62% <100.00%> (ø)
databricks/koalas/internal.py 96.47% <100.00%> (+0.01%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809ed86...5abd90d. Read the comment docs.

@ueshin ueshin marked this pull request as ready for review December 1, 2020 21:23
Copy link
Contributor

@itholic itholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!

@HyukjinKwon
Copy link
Member

+1, nice.

@xinrong-meng
Copy link
Contributor

Awesome! Thank you!

@ueshin
Copy link
Collaborator Author

ueshin commented Dec 2, 2020

Thanks! I'd merge this now.

@ueshin ueshin merged commit 138c7b8 into databricks:master Dec 2, 2020
@ueshin ueshin deleted the index_spark_columns branch December 2, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants