-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DataFrame parameter in Series.dot #1931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an example using DataFrame
in the docstring?
Codecov Report
@@ Coverage Diff @@
## master #1931 +/- ##
==========================================
+ Coverage 94.50% 94.63% +0.13%
==========================================
Files 45 49 +4
Lines 10682 10829 +147
==========================================
+ Hits 10095 10248 +153
+ Misses 587 581 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we add a type annotation for the argument other
?
Could you add more tests like: pdf = pd.DataFrame({"a": [1, 2, 3], "b": [4, 5, 6]})
kdf = ks.from_pandas(pdf)
self.assert_eq((pdf['b'] * 10).dot(pdf['a']), ...)
self.assert_eq((pdf['b'] * 10).dot(pdf), ...)
self.assert_eq((pdf['b'] * 10).dot(pdf + 1), ...) |
a783973
to
7dbad5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, seems good to me.
8125170
to
10127ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks! I'd merge this now. |
Thank you! |
No description provided.