Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DataFrame parameter in Series.dot #1931

Merged
merged 30 commits into from
Dec 4, 2020

Conversation

xinrong-meng
Copy link
Contributor

No description provided.

@xinrong-meng xinrong-meng marked this pull request as draft November 25, 2020 17:32
Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an example using DataFrame in the docstring?

databricks/koalas/series.py Outdated Show resolved Hide resolved
databricks/koalas/tests/test_series.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Nov 25, 2020

Codecov Report

Merging #1931 (10127ac) into master (8d35a74) will increase coverage by 0.13%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1931      +/-   ##
==========================================
+ Coverage   94.50%   94.63%   +0.13%     
==========================================
  Files          45       49       +4     
  Lines       10682    10829     +147     
==========================================
+ Hits        10095    10248     +153     
+ Misses        587      581       -6     
Impacted Files Coverage Δ
databricks/koalas/series.py 96.87% <88.23%> (-0.17%) ⬇️
databricks/koalas/utils.py 95.71% <0.00%> (ø)
databricks/koalas/groupby.py 91.42% <0.00%> (ø)
databricks/koalas/indexing.py 92.62% <0.00%> (ø)
databricks/koalas/namespace.py 84.23% <0.00%> (ø)
databricks/koalas/spark/accessors.py 94.96% <0.00%> (ø)
databricks/koalas/tests/plot/test_series_plot.py 100.00% <0.00%> (ø)
databricks/koalas/plot.py
databricks/koalas/plot/core.py 92.77% <0.00%> (ø)
databricks/koalas/plot/__init__.py 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d35a74...10127ac. Read the comment docs.

@xinrong-meng xinrong-meng marked this pull request as ready for review November 30, 2020 21:18
Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a type annotation for the argument other?

databricks/koalas/series.py Outdated Show resolved Hide resolved
databricks/koalas/series.py Outdated Show resolved Hide resolved
databricks/koalas/series.py Outdated Show resolved Hide resolved
databricks/koalas/series.py Outdated Show resolved Hide resolved
databricks/koalas/series.py Outdated Show resolved Hide resolved
@ueshin
Copy link
Collaborator

ueshin commented Nov 30, 2020

Could you add more tests like:

pdf = pd.DataFrame({"a": [1, 2, 3], "b": [4, 5, 6]})
kdf = ks.from_pandas(pdf)

self.assert_eq((pdf['b'] * 10).dot(pdf['a']), ...)
self.assert_eq((pdf['b'] * 10).dot(pdf), ...)
self.assert_eq((pdf['b'] * 10).dot(pdf + 1), ...)

databricks/koalas/series.py Outdated Show resolved Hide resolved
databricks/koalas/series.py Outdated Show resolved Hide resolved
Copy link
Contributor

@itholic itholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, seems good to me.

databricks/koalas/series.py Show resolved Hide resolved
Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ueshin
Copy link
Collaborator

ueshin commented Dec 4, 2020

Thanks! I'd merge this now.

@ueshin ueshin merged commit 901a6f0 into databricks:master Dec 4, 2020
@xinrong-meng
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants