Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type annotations to Koalas accessors and Spark accessors #1902

Merged
merged 5 commits into from
Nov 11, 2020

Conversation

xinrong-meng
Copy link
Contributor

No description provided.

databricks/koalas/accessors.py Outdated Show resolved Hide resolved
databricks/koalas/accessors.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending tests.

@codecov-io
Copy link

codecov-io commented Nov 11, 2020

Codecov Report

Merging #1902 (5203dc4) into master (674cdd2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1902      +/-   ##
==========================================
+ Coverage   94.14%   94.16%   +0.01%     
==========================================
  Files          41       41              
  Lines        9979     9975       -4     
==========================================
- Hits         9395     9393       -2     
+ Misses        584      582       -2     
Impacted Files Coverage Δ
databricks/koalas/accessors.py 93.00% <100.00%> (ø)
databricks/koalas/spark/accessors.py 94.96% <100.00%> (ø)
databricks/koalas/utils.py 95.71% <0.00%> (-0.36%) ⬇️
databricks/koalas/indexes.py 96.81% <0.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 674cdd2...5203dc4. Read the comment docs.

@xinrong-meng
Copy link
Contributor Author

@ueshin Thank you!

@xinrong-meng xinrong-meng merged commit 44d45f2 into databricks:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants