Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly disallow empty list as index_spark_colum_names and index_names. #1895

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Nov 7, 2020

When an empty list is passed to IndexFrame.index_spark_column_names or .index_names, currently it passes without any errors and it will cause an unexpected error in other places.
We should handle the empty list the same as None.

@codecov-io
Copy link

codecov-io commented Nov 7, 2020

Codecov Report

Merging #1895 (478b0e5) into master (3237002) will increase coverage by 0.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1895      +/-   ##
==========================================
+ Coverage   94.20%   94.22%   +0.01%     
==========================================
  Files          40       40              
  Lines        9939     9932       -7     
==========================================
- Hits         9363     9358       -5     
+ Misses        576      574       -2     
Impacted Files Coverage Δ
databricks/koalas/groupby.py 91.47% <11.11%> (+0.28%) ⬆️
databricks/koalas/frame.py 96.72% <100.00%> (-0.01%) ⬇️
databricks/koalas/internal.py 96.47% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3237002...478b0e5. Read the comment docs.

@HyukjinKwon HyukjinKwon merged commit 5a7c2fc into databricks:master Nov 9, 2020
@ueshin ueshin deleted the internal branch November 9, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants