Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations to Frame (generic.py) #1894

Merged
merged 5 commits into from
Nov 7, 2020

Conversation

xinrong-meng
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 6, 2020

Codecov Report

Merging #1894 (6a43f3c) into master (3237002) will decrease coverage by 0.04%.
The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1894      +/-   ##
==========================================
- Coverage   94.20%   94.15%   -0.05%     
==========================================
  Files          40       40              
  Lines        9939     9960      +21     
==========================================
+ Hits         9363     9378      +15     
- Misses        576      582       +6     
Impacted Files Coverage Δ
databricks/koalas/generic.py 93.89% <88.46%> (-1.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3237002...6a43f3c. Read the comment docs.

databricks/koalas/generic.py Outdated Show resolved Hide resolved
databricks/koalas/generic.py Outdated Show resolved Hide resolved
databricks/koalas/generic.py Outdated Show resolved Hide resolved
databricks/koalas/generic.py Show resolved Hide resolved
Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending tests.

@ueshin
Copy link
Collaborator

ueshin commented Nov 7, 2020

Thanks! merging.

@ueshin ueshin merged commit bc70448 into databricks:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants