Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce df.spark.repartition #1864

Merged
merged 15 commits into from
Oct 24, 2020
Merged

Introduce df.spark.repartition #1864

merged 15 commits into from
Oct 24, 2020

Conversation

xinrong-meng
Copy link
Contributor

No description provided.

ueshin
ueshin reviewed Oct 22, 2020
View reviewed changes
databricks/koalas/spark/accessors.py Outdated Show resolved Hide resolved
databricks/koalas/frame.py Outdated Show resolved Hide resolved
databricks/koalas/spark/accessors.py Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 22, 2020 •
edited
Loading

Codecov Report

Merging #1864 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1864   +/-   ##
=======================================
  Coverage   94.15%   94.16%           
=======================================
  Files          40       40           
  Lines        9810     9815    +5     
=======================================
+ Hits         9237     9242    +5     
  Misses        573      573
Impacted Files Coverage Δ
databricks/koalas/spark/accessors.py 93.75% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deefc2c...838f4c1. Read the comment docs.

ueshin
ueshin reviewed Oct 23, 2020
View reviewed changes
databricks/koalas/tests/test_dataframe.py Outdated Show resolved Hide resolved
databricks/koalas/tests/test_dataframe.py Outdated Show resolved Hide resolved
ueshin
ueshin reviewed Oct 24, 2020
View reviewed changes
Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM, pending tests.

databricks/koalas/spark/accessors.py Outdated Show resolved Hide resolved
HyukjinKwon
HyukjinKwon approved these changes Oct 24, 2020
View reviewed changes
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. We can also add coalesce I guess :-). Also this should be added into doc.

@xinrong-meng xinrong-meng marked this pull request as ready for review October 24, 2020 01:29
@xinrong-meng
Copy link
Contributor Author

@HyukjinKwon Sounds good! Thank you for your approval!

@xinrong-meng xinrong-meng merged commit 98f895a into databricks:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

@ueshin ueshin Awaiting requested review from ueshin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xinrong-meng @codecov-io @ueshin @HyukjinKwon