Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return type of groupby #1852

Merged
merged 3 commits into from
Oct 16, 2020
Merged

Add return type of groupby #1852

merged 3 commits into from
Oct 16, 2020

Conversation

xinrong-meng
Copy link
Contributor

@xinrong-meng xinrong-meng commented Oct 15, 2020 •
edited by HyukjinKwon
Loading

This PR adds the type hints for its return type at Series.groupby and DataFrame.groupby.

ueshin
ueshin approved these changes Oct 16, 2020
View reviewed changes
Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HyukjinKwon HyukjinKwon marked this pull request as ready for review October 16, 2020 02:12
@HyukjinKwon HyukjinKwon merged commit e03bea4 into databricks:master Oct 16, 2020
@itholic
Copy link
Contributor

itholic commented Oct 16, 2020

Nice fix 👍

@xinrong-meng
Copy link
Contributor Author

Thank you @ueshin @itholic for review and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

@ueshin ueshin ueshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xinrong-meng @itholic @ueshin @HyukjinKwon