Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Series.product #1677

Merged
merged 12 commits into from
Aug 4, 2020
Merged

Add Series.product #1677

merged 12 commits into from
Aug 4, 2020

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Jul 26, 2020 •
edited
Loading

Implemented Series.product (Series.prod as an alias).

*Note that since It is implemented by using exp(sum(log(...))) trick, it only works for positive numbers.

>>> ks.Series([]).prod()
1.0
>>> ks.Series([1, 2, 3, 4, 5]).prod()
120
>>> ks.Series([1, np.nan, 3, np.nan, 5]).prod()
15.0

ueshin
ueshin reviewed Jul 27, 2020
View reviewed changes
databricks/koalas/series.py Outdated Show resolved Hide resolved
databricks/koalas/tests/test_series.py Outdated Show resolved Hide resolved
databricks/koalas/tests/test_series.py Outdated Show resolved Hide resolved
ueshin
ueshin reviewed Jul 28, 2020
View reviewed changes
databricks/koalas/series.py Outdated Show resolved Hide resolved
HyukjinKwon
HyukjinKwon approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise.

@itholic
Copy link
Contributor Author

itholic commented Jul 31, 2020

Thanks, @HyukjinKwon .

itholic
itholic commented Jul 31, 2020
View reviewed changes
Copy link
Contributor Author

@itholic itholic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This comment is posted by mistake. I have no idea how to delete this 😅)

ueshin
ueshin approved these changes Jul 31, 2020
View reviewed changes
Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM.

databricks/koalas/series.py Outdated Show resolved Hide resolved
databricks/koalas/series.py Outdated Show resolved Hide resolved
databricks/koalas/series.py Outdated Show resolved Hide resolved
@HyukjinKwon
Copy link
Member

@itholic can you address the comments above?

@HyukjinKwon HyukjinKwon merged commit faf687f into databricks:master Aug 4, 2020
@itholic itholic deleted the prod branch August 11, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

@ueshin ueshin ueshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itholic @HyukjinKwon @ueshin