Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine concat to handle the same anchor DataFrames properly. #1627

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Refine concat to handle the same anchor DataFrames properly. #1627

merged 2 commits into from
Jul 8, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Jul 3, 2020

Refine concat to handle the same anchor DataFrames properly and reduce unnecessary internal joins.

@ueshin ueshin requested a review from HyukjinKwon July 3, 2020 02:38
@ueshin ueshin mentioned this pull request Jul 8, 2020
Merged
HyukjinKwon
HyukjinKwon reviewed Jul 8, 2020
View reviewed changes
databricks/koalas/namespace.py
concat_kdf = kdfs[0]
column_labels = concat_kdf._internal.column_labels.copy()

kdfs_not_same_anchor = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kdfs_different_anchor :-)?

@HyukjinKwon HyukjinKwon merged commit 6a47ff6 into databricks:master Jul 8, 2020
@ueshin ueshin deleted the concat branch July 8, 2020 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ueshin @HyukjinKwon