-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for API extensions #1617
Conversation
Hmm, looks like 3.5 testing is in the pipe? Failing checks 1 and 2 because of f-strings. From the docs:
If 3.5+ support is required, I can rollback and add a to fix the docs, as well. Rest of the failures (3.6+) are from one the doctests of the testing utility that I uncritically replicated from pandas._testing. Will take a look. Edit:3.6+ now passing. The testing utility itself is fine, but the outputs in the pipeline don't match up precisely, so I skipped them.
Output in the pipeline that caused original check failures is still AssertionError, just more verbose:
Edit 2:Fixed for 3.5, as well. |
Thanks @scook12 for working on this. Seems fine from a cursory look but let me take a closer look within few days. |
Sounds good! Thanks. |
Otherwise, LGTM. Thanks! |
Alright, think I got 'em all. Let me know if there's any other changes you wanted or if I missed something. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM.
I'd leave this to @HyukjinKwon.
Thanks for working on this!
…Test, inherit ReusedSQLTestCase
""" | ||
Register a custom accessor on {klass} objects. | ||
|
||
Parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe underline is missing? :)
Parameters
----------
databricks/koalas/extensions.py
Outdated
name : str | ||
name used when calling the accessor after its registered | ||
|
||
Returns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: indent
databricks/koalas/extensions.py
Outdated
|
||
See Also | ||
-------- | ||
register_dataframe_accessor: Register a custom accessor on Series objects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Series objects
-> DataFrame objects
?
databricks/koalas/extensions.py
Outdated
|
||
See Also | ||
-------- | ||
register_dataframe_accessor: Register a custom accessor on Series objects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
databricks/koalas/extensions.py
Outdated
See Also | ||
-------- | ||
register_dataframe_accessor: Register a custom accessor on Series objects | ||
register_series_accessor: Register a custom accessor on Index objects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Index objects
-> Series objects
?
Otherwise, LGTM 👍 |
This is awesome. Thanks @scook12. Merged. |
Great! thanks @HyukjinKwon, happy to do it. |
This should close #1465 and #1285.