Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for new type hints in Koalas #1584

Merged
merged 2 commits into from
Jun 19, 2020

Conversation

HyukjinKwon
Copy link
Member

This PR adds some documentations for #1578

Screen Shot 2020-06-16 at 7 07 34 PM
Screen Shot 2020-06-16 at 7 07 50 PM

@HyukjinKwon HyukjinKwon requested a review from ueshin June 16, 2020 10:09
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2020

Codecov Report

Merging #1584 into master will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1584      +/-   ##
==========================================
+ Coverage   94.25%   94.57%   +0.31%     
==========================================
  Files          38       38              
  Lines        8691     8789      +98     
==========================================
+ Hits         8192     8312     +120     
+ Misses        499      477      -22     
Impacted Files Coverage Δ
databricks/koalas/usage_logging/__init__.py 91.37% <0.00%> (-3.27%) ⬇️
databricks/koalas/missing/__init__.py 100.00% <0.00%> (ø)
databricks/koalas/config.py 99.00% <0.00%> (+0.01%) ⬆️
databricks/koalas/utils.py 96.38% <0.00%> (+0.01%) ⬆️
databricks/koalas/series.py 97.63% <0.00%> (+0.01%) ⬆️
databricks/koalas/indexes.py 96.86% <0.00%> (+0.03%) ⬆️
databricks/koalas/generic.py 96.71% <0.00%> (+0.06%) ⬆️
databricks/koalas/plot.py 94.36% <0.00%> (+0.08%) ⬆️
databricks/koalas/indexing.py 92.25% <0.00%> (+0.08%) ⬆️
databricks/koalas/base.py 97.37% <0.00%> (+0.09%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff3a68e...41fa7b6. Read the comment docs.

@itholic
Copy link
Contributor

itholic commented Jun 17, 2020

Looks really good to me !
(And also, how about we merge this and #1589 right after 1.0.0 will be actually released ??)

@HyukjinKwon
Copy link
Member Author

The documentation should be the part of the release so it should include.

@itholic
Copy link
Contributor

itholic commented Jun 17, 2020

@HyukjinKwon Ah, makes sense.

@HyukjinKwon
Copy link
Member Author

I am merging this to unblock the release.

@HyukjinKwon HyukjinKwon merged commit 84fabc6 into databricks:master Jun 19, 2020
@HyukjinKwon HyukjinKwon deleted the typehints-doc branch September 11, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants