Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataFrame.replace to avoid creating a new Spark DataFrame. #1575

Merged
merged 2 commits into from
Jun 12, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Jun 11, 2020

DataFrame.replace() doesn't need to create a new Spark DataFrame.

@ueshin ueshin requested a review from HyukjinKwon June 11, 2020 21:05
@ueshin
Copy link
Collaborator Author

ueshin commented Jun 11, 2020

also cc @beobest2

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2020

Codecov Report

Merging #1575 into master will decrease coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1575      +/-   ##
==========================================
- Coverage   94.56%   94.24%   -0.32%     
==========================================
  Files          38       38              
  Lines        8773     8668     -105     
==========================================
- Hits         8296     8169     -127     
- Misses        477      499      +22     
Impacted Files Coverage Δ
databricks/koalas/frame.py 95.94% <100.00%> (-0.89%) ⬇️
databricks/conftest.py 96.22% <0.00%> (-3.78%) ⬇️
databricks/koalas/typedef/typehints.py 85.26% <0.00%> (-2.11%) ⬇️
databricks/koalas/__init__.py 92.15% <0.00%> (-1.97%) ⬇️
databricks/koalas/testing/utils.py 78.98% <0.00%> (-1.81%) ⬇️
databricks/koalas/spark/accessors.py 91.66% <0.00%> (-1.08%) ⬇️
databricks/koalas/internal.py 96.80% <0.00%> (-0.75%) ⬇️
databricks/koalas/mlflow.py 94.87% <0.00%> (-0.13%) ⬇️
databricks/koalas/groupby.py 90.42% <0.00%> (-0.10%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a02fe6e...abc10dd. Read the comment docs.

@itholic
Copy link
Contributor

itholic commented Jun 12, 2020

LGTM

@HyukjinKwon HyukjinKwon merged commit 3a6cf5a into databricks:master Jun 12, 2020
@ueshin ueshin deleted the replace branch June 12, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants