Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hasnans to follow the modified column. #1532

Merged
merged 2 commits into from
May 25, 2020
Merged

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented May 23, 2020

Fixing hasnans to follow the modified column.

E.g.,

>>> (ks.Series([1.0, 2.0, np.nan]) + 1).hasnans
Traceback (most recent call last):
...
pyspark.sql.utils.AnalysisException: 'Resolved attribute(s) 0#1 missing from (0 + 1)#10 in operator ...

@ueshin ueshin requested a review from HyukjinKwon May 23, 2020 01:09
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2020

Codecov Report

Merging #1532 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1532      +/-   ##
==========================================
- Coverage   94.15%   94.15%   -0.01%     
==========================================
  Files          37       37              
  Lines        8509     8508       -1     
==========================================
- Hits         8012     8011       -1     
  Misses        497      497              
Impacted Files Coverage Δ
databricks/koalas/base.py 97.27% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25117cb...60a677d. Read the comment docs.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ueshin
Copy link
Collaborator Author

ueshin commented May 25, 2020

Thanks! merging.

@ueshin ueshin merged commit 050a301 into databricks:master May 25, 2020
@ueshin ueshin deleted the hasnans branch May 25, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants