Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __bool__ function. #1526

Merged
merged 2 commits into from
May 22, 2020
Merged

Add __bool__ function. #1526

merged 2 commits into from
May 22, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented May 21, 2020

Adding __bool__ function explicitly to raise an error when DataFrame, Series, and Index are used as bool, otherwise they might be used mistakenly.

@ueshin ueshin requested a review from HyukjinKwon May 21, 2020 22:53
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2020

Codecov Report

Merging #1526 into master will decrease coverage by 0.02%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1526      +/-   ##
==========================================
- Coverage   94.02%   94.00%   -0.03%     
==========================================
  Files          36       36              
  Lines        8479     8484       +5     
==========================================
+ Hits         7972     7975       +3     
- Misses        507      509       +2     
Impacted Files Coverage Δ
databricks/koalas/generic.py 96.67% <50.00%> (-0.35%) ⬇️
databricks/koalas/indexes.py 96.89% <50.00%> (-0.18%) ⬇️
databricks/koalas/utils.py 96.39% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f004ce...1c2ae26. Read the comment docs.

@HyukjinKwon HyukjinKwon merged commit c972da8 into databricks:master May 22, 2020
@ueshin ueshin deleted the bool branch May 22, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants