Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GroupBy.fillna to use GroupBy._apply_series_op. #1481

Merged
merged 1 commit into from
May 12, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented May 12, 2020

GroupBy.fillna can also use GroupBy._apply_series_op instead of its own logic to collect Series.

@ueshin ueshin requested a review from HyukjinKwon May 12, 2020 00:25
@codecov-io
Copy link

codecov-io commented May 12, 2020

Codecov Report

Merging #1481 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1481      +/-   ##
==========================================
- Coverage   93.80%   93.79%   -0.01%     
==========================================
  Files          36       36              
  Lines        8440     8430      -10     
==========================================
- Hits         7917     7907      -10     
  Misses        523      523              
Impacted Files Coverage Δ
databricks/koalas/groupby.py 89.17% <100.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d13a76f...fea1e03. Read the comment docs.

@HyukjinKwon HyukjinKwon merged commit dc5dba6 into databricks:master May 12, 2020
@ueshin ueshin deleted the groupby_fillna branch May 12, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants