Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix named aggregation for MultiIndex #1435

Merged
merged 11 commits into from
May 4, 2020

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Apr 21, 2020

This PR takes over #1000.

Closes #1000

@codecov-io
Copy link

codecov-io commented Apr 21, 2020

Codecov Report

Merging #1435 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1435   +/-   ##
=======================================
  Coverage   94.00%   94.00%           
=======================================
  Files          36       36           
  Lines        8342     8344    +2     
=======================================
+ Hits         7842     7844    +2     
  Misses        500      500           
Impacted Files Coverage Δ
databricks/koalas/groupby.py 91.83% <ø> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a6679...3e504c4. Read the comment docs.

@ueshin
Copy link
Collaborator

ueshin commented Apr 29, 2020

The build for Conda (Python, Spark, pandas, PyArrow) (3.7, 2.4.5, 1.0.3, 0.15.1) environment must be fixed.

@itholic Could you push an empty commit to rerun tests?
Seems like "Re-run jobs" button reruns exactly the same job, without updating master branch.

@itholic
Copy link
Contributor Author

itholic commented May 1, 2020

@ueshin

Thanks! I just rebased this PR to master.

@HyukjinKwon HyukjinKwon merged commit caf8bb5 into databricks:master May 4, 2020
@itholic itholic deleted the named_agg_mi_cherry branch May 29, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants