Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatible behaviour with pandas for floordiv with np.nan #1429

Merged
merged 3 commits into from
Apr 20, 2020

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Apr 17, 2020

Resolves #1428

>>> pser = pd.Series([-100, 0, 100, None, np.nan], name="Koalas")
>>> kser = ks.from_pandas(pser)

>>> pser // np.nan
0   NaN
1   NaN
2   NaN
3   NaN
4   NaN
Name: Koalas, dtype: float64

>>> kser // np.nan                                                                                                                
0   NaN
1   NaN
2   NaN
3   NaN
4   NaN
Name: Koalas, dtype: float64

@codecov-io
Copy link

codecov-io commented Apr 17, 2020

Codecov Report

Merging #1429 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1429   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files          34       34           
  Lines        7967     7967           
=======================================
  Hits         7580     7580           
  Misses        387      387           
Impacted Files Coverage Δ
databricks/koalas/base.py 97.64% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83e44bf...5c96153. Read the comment docs.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

@HyukjinKwon HyukjinKwon merged commit 5b3563b into databricks:master Apr 20, 2020
@itholic itholic deleted the fix_floordiv branch April 21, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with pandas when floordiv with np.nan
3 participants