Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MultiIndex in DataFrame.unstack. #1322

Merged
merged 3 commits into from
Mar 4, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Mar 3, 2020

We can support unstack with MultiIndex using pivot_table.
But as discussed at #886 (comment), we should still be careful to use it.

@ueshin ueshin requested a review from HyukjinKwon March 3, 2020 23:00
@codecov-io
Copy link

codecov-io commented Mar 3, 2020

Codecov Report

Merging #1322 into master will decrease coverage by 1.35%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1322      +/-   ##
==========================================
- Coverage   95.23%   93.87%   -1.36%     
==========================================
  Files          34       34              
  Lines        7339     7345       +6     
==========================================
- Hits         6989     6895      -94     
- Misses        350      450     +100
Impacted Files Coverage Δ
databricks/koalas/frame.py 96.72% <100%> (+0.01%) ⬆️
databricks/koalas/usage_logging/__init__.py 24.32% <0%> (-71.18%) ⬇️
databricks/koalas/usage_logging/usage_logger.py 50% <0%> (-50%) ⬇️
databricks/koalas/__init__.py 78.72% <0%> (-14.9%) ⬇️
databricks/conftest.py 92.45% <0%> (-3.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f43fc6...66ce526. Read the comment docs.

This reverts commit 355c844.
@ueshin
Copy link
Collaborator Author

ueshin commented Mar 4, 2020

We need to revisit pivot_table later. I will handle it in a separate PR.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@HyukjinKwon HyukjinKwon merged commit 1eb7023 into databricks:master Mar 4, 2020
@ueshin ueshin deleted the unstack branch March 4, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants