Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache properly for conda env, name jobs pretty and separate dependency installation and run tests in Github Actions #1264

Merged
merged 2 commits into from
Feb 9, 2020
Merged

Cache properly for conda env, name jobs pretty and separate dependency installation and run tests in Github Actions #1264

merged 2 commits into from
Feb 9, 2020

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Feb 9, 2020 •
edited
Loading

  • Cache properly for conda env. We should better cache environment.
  • Name jobs pretty
  • Separate dependency installation and run tests in Github Actions
  • Minor commets fixes.

@HyukjinKwon HyukjinKwon changed the title Name jobs pretty and separate dependency installation and run tests in Github Actions [WIP] Name jobs pretty and separate dependency installation and run tests in Github Actions Feb 9, 2020
@HyukjinKwon HyukjinKwon force-pushed the github-actions branch 3 times, most recently from 2817ad8 to 970c1fc Compare February 9, 2020 03:05
@itholic
Copy link
Contributor

itholic commented Feb 9, 2020 •
edited
Loading

just FYI maybe you already know that:

  • if one of test in same matrix has failed, others also cancelled automatically (fail-fast)
  • i did'n try, but i'm pretty sure you can change this behavior if you want like that
strategy:
  matrix:
    python-version: [3.6, 3.7]
  fail-fast: false  # default true

@codecov-io
Copy link

codecov-io commented Feb 9, 2020 •
edited
Loading

Codecov Report

Merging #1264 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1264   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files          35       35           
  Lines        7151     7151           
=======================================
  Hits         6805     6805           
  Misses        346      346

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2b00a...b392cf4. Read the comment docs.

@HyukjinKwon
Copy link
Member Author

Yeah, I have a bit of experience with Github Actions :-).

@HyukjinKwon
Copy link
Member Author

okay.. seems working fine.

@HyukjinKwon HyukjinKwon changed the title [WIP] Name jobs pretty and separate dependency installation and run tests in Github Actions Cache properly for conda env, name jobs pretty and separate dependency installation and run tests in Github Actions Feb 9, 2020
@HyukjinKwon
Copy link
Member Author

BTW, I discussed offline with @ueshin. Let's keep Travis CI for now and see how Github Actions build are stable.

@itholic
Copy link
Contributor

itholic commented Feb 9, 2020

@HyukjinKwon okay, i also think it's better

itholic
itholic reviewed Feb 9, 2020
View reviewed changes
.github/workflows/master.yml Outdated
runs-on: ubuntu-latest
env:
SPARK_VERSION: 2.3.4
PANDAS_VERSION: 0.23.4
PYARROW_VERSION: 0.10.0
# DISPLAY=0.0 does not work in Github Actions with Python 3.5. Here we work around wtih xvfb-run
Copy link
Contributor

@itholic itholic Feb 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: seems to be there are two spaces between wtih and xvfb-run

itholic
itholic reviewed Feb 9, 2020
View reviewed changes
.github/workflows/master.yml
# for some reasons we should add enviornment directory manually to allow for
# 'test-enviornment' to be found. See also https://github.com/conda/conda/issues/7980
. $HOME/miniconda/etc/profile.d/conda.sh
conda config --prepend envs_dirs /home/runner/miniconda/envs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@itholic
Copy link
Contributor

itholic commented Feb 9, 2020

LGTM

@HyukjinKwon
Copy link
Member Author

Github Actions passed. I will just merge.

@HyukjinKwon HyukjinKwon merged commit 31b9ae0 into databricks:master Feb 9, 2020
@HyukjinKwon HyukjinKwon deleted the github-actions branch September 11, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itholic itholic itholic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HyukjinKwon @itholic @codecov-io