-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to GitHub Actions #1254
Conversation
Since it is very first time to me using GitHub Actions, need some advice 😅 |
Codecov Report
@@ Coverage Diff @@
## master #1254 +/- ##
==========================================
- Coverage 95.09% 93.79% -1.31%
==========================================
Files 35 35
Lines 7154 7151 -3
==========================================
- Hits 6803 6707 -96
- Misses 351 444 +93
Continue to review full report at Codecov.
|
Is it possible to cache Spark as the current Travis config does? Lines 3 to 5 in 0e56ea4
|
@harupy hey, how have you been :) i have tried yesterday like the below with using - uses: actions/cache@v1
id: cache
with:
path: $HOME/.cache/spark-versions but they want me the - uses: actions/cache@v1
id: cache
with:
path: $HOME/.cache/spark-versions
key: ${{ runner.os }}-primes Any idea what value I should put in FYI, they say about |
@itholic I think you can use |
@HyukjinKwon |
Just FYI
|
@harupy thanks for reminding me!! :D |
i'm working for adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise.
Applied matrix to integrate python 3.6 & 3.7 tests. |
This issue does not seem to be fixed yet. |
@harupy Thanks for the report! 😃 Maybe we should delay merging this PR until that issue solved. I'll test on my repository and try out to find the solution. Thanks :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, LGTM. let's give a shot.
I suggest introducing GitHub Actions to Koalas.
Since it is a tool provided by GitHub itself, I think that stable support for GitHub repository is possible compared to other CI tools.
Currently it supports 20 concurrent jobs vs Travis 3 concurrent jobs.
It also support Mac and Windows.
And i think it's simple to use and the marketplace is so active that it's easy to apply a lot of additional features in the future.