Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identical and equals for the comparison between the same object. #1220

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Jan 23, 2020

identical and equals should be True for the comparison between the same object.

>>> import pandas as pd
>>> idx = pd.Index(['a', 'b', 'c'])
>>> midx = pd.MultiIndex.from_tuples([('a', 'x'), ('b', 'y'), ('c', 'z')])
>>> midx.names = ("nameA", "nameB")

>>> idx.identical(idx)
True
>>> midx.identical(midx)
True

>>> idx.equals(idx)
True
>>> midx.equals(midx)
True

@ueshin ueshin changed the title Fix identical and equals. Fix identical and equals for the comparison between the same object.. Jan 23, 2020
@ueshin ueshin changed the title Fix identical and equals for the comparison between the same object.. Fix identical and equals for the comparison between the same object. Jan 23, 2020
@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

Merging #1220 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1220   +/-   ##
======================================
  Coverage    95.2%   95.2%           
======================================
  Files          35      35           
  Lines        7257    7257           
======================================
  Hits         6909    6909           
  Misses        348     348
Impacted Files Coverage Δ
databricks/koalas/indexes.py 96% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbb4ede...9e602d0. Read the comment docs.

@HyukjinKwon
Copy link
Member

Oops, thanks for fixing this. @ueshin.

@HyukjinKwon HyukjinKwon merged commit 3c8c4e2 into databricks:master Jan 24, 2020
@ueshin ueshin deleted the identical_equals branch January 24, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants