Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon to doc #1189

Merged
merged 2 commits into from
Jan 11, 2020
Merged

Add favicon to doc #1189

merged 2 commits into from
Jan 11, 2020

Conversation

harupy
Copy link
Contributor

@harupy harupy commented Jan 10, 2020

This PR adds a favicon to the doc.

Screen Shot 2020-01-10 at 22 05 34

@codecov-io
Copy link

codecov-io commented Jan 10, 2020

Codecov Report

Merging #1189 into master will decrease coverage by 2.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1189      +/-   ##
==========================================
- Coverage   95.24%   92.72%   -2.52%     
==========================================
  Files          35       35              
  Lines        7105     7105              
==========================================
- Hits         6767     6588     -179     
- Misses        338      517     +179
Impacted Files Coverage Δ
databricks/koalas/usage_logging/__init__.py 24.32% <0%> (-72.98%) ⬇️
databricks/koalas/usage_logging/usage_logger.py 50% <0%> (-50%) ⬇️
databricks/koalas/__init__.py 78.72% <0%> (-6.39%) ⬇️
databricks/conftest.py 92% <0%> (-6%) ⬇️
databricks/koalas/frame.py 93.74% <0%> (-3.27%) ⬇️
databricks/koalas/groupby.py 89.6% <0%> (-2%) ⬇️
databricks/koalas/namespace.py 86.06% <0%> (-1.52%) ⬇️
databricks/koalas/plot.py 93.33% <0%> (-0.96%) ⬇️
databricks/koalas/testing/utils.py 77.77% <0%> (-0.75%) ⬇️
databricks/koalas/utils.py 95.09% <0%> (-0.62%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d43f302...1f9904a. Read the comment docs.

@ueshin
Copy link
Collaborator

ueshin commented Jan 11, 2020

Thanks! merging.

@ueshin ueshin merged commit 10111f6 into databricks:master Jan 11, 2020
@harupy harupy deleted the add-favicon branch January 11, 2020 02:07
@harupy
Copy link
Contributor Author

harupy commented Jan 11, 2020

It seems to be working fine.

Screen Shot 2020-01-11 at 14 47 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants