-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix .loc to work properly when using 'slice' #1159
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1159 +/- ##
==========================================
+ Coverage 95.22% 95.24% +0.01%
==========================================
Files 35 35
Lines 7058 7087 +29
==========================================
+ Hits 6721 6750 +29
Misses 337 337
Continue to review full report at Codecov.
|
hmm.. i have no idea why codecov has failed although it seems that tests are covering all cases |
btw, we can remove line 236?
|
Resolves #1173 |
Looks fine otherwise. |
Thanks, merged. |
Resolve #1158