Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Index.fillna #1102

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Implement Index.fillna #1102

merged 2 commits into from
Dec 5, 2019

Conversation

RainFung
Copy link
Contributor

@RainFung RainFung commented Dec 3, 2019

Implement Index.fillna via spark.DataFrame.fillna

@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #1102 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1102      +/-   ##
=========================================
- Coverage   95.21%   95.2%   -0.02%     
=========================================
  Files          34      34              
  Lines        6896    6939      +43     
=========================================
+ Hits         6566    6606      +40     
- Misses        330     333       +3
Impacted Files Coverage Δ
databricks/koalas/missing/indexes.py 100% <ø> (ø) ⬆️
databricks/koalas/indexes.py 96.29% <100%> (+0.09%) ⬆️
databricks/koalas/base.py 94.88% <0%> (-1.02%) ⬇️
databricks/koalas/missing/frame.py 100% <0%> (ø) ⬆️
databricks/koalas/frame.py 96.76% <0%> (+0.02%) ⬆️
databricks/koalas/series.py 96.5% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b0014f...86da483. Read the comment docs.

@softagram-bot
Copy link

Softagram Impact Report for pull/1102 (head commit: 86da483)

⚠️ Copy paste found

ℹ️ indexes.py: Copy paste fragment inside the same file on lines 691, 967:

            raise NotImplementedError(
                \"Doesn't support symmetric_difference between Index & MultiIndex for now\")

        sdf_self = self._kdf._s...(truncated 477 chars)

ℹ️ test_indexes.py: Copy paste fragment on line 30 shared with ../test_dataframe.py:


    @property
    def pdf(self):
        return pd.DataFrame({
            'a': [1, 2, 3, 4, 5, 6, 7, 8, 9],
            'b': [4, 5, 6, 3, 2, 1, ...(truncated 160 chars)

ℹ️ test_indexes.py: Copy paste fragment on line 33 shared with ../test_dataframe.py, ../test_ops_on_diff_frames.py:

        return pd.DataFrame({
            'a': [1, 2, 3, 4, 5, 6, 7, 8, 9],
            'b': [4, 5, 6, 3, 2, 1, 0, 0, 0],
        }, index=[0, 1, 3, 5, 6, 8, 9, 9, 9])

    @propert...(truncated 20 chars)

ℹ️ indexes.py: Copy paste fragment inside the same file on lines 39, 128:

    flags = unsupported_property('flags', deprecated=True)

    # Functions
    append = unsupported_function('append')
    argmax = unsupporte...(truncated 500 chars)

Now that you are on the file, it would be easier to pay back some tech. debt.

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@ueshin
Copy link
Collaborator

ueshin commented Dec 5, 2019

LGTM.

@ueshin
Copy link
Collaborator

ueshin commented Dec 5, 2019

Thanks! merging.

@ueshin ueshin merged commit 2bd7adc into databricks:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants