Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly block Index ^ MultiIndex for Index.symmetric_difference #1059

Merged
merged 10 commits into from
Nov 22, 2019

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Nov 19, 2019

Related with #953 (comment) and #953 (comment)

@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #1059 into master will decrease coverage by 0.01%.
The diff coverage is 93.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
- Coverage   95.19%   95.18%   -0.02%     
==========================================
  Files          34       34              
  Lines        6810     6837      +27     
==========================================
+ Hits         6483     6508      +25     
- Misses        327      329       +2
Impacted Files Coverage Δ
databricks/koalas/missing/indexes.py 100% <ø> (ø) ⬆️
databricks/koalas/indexes.py 96.05% <93.1%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7070bc6...242ec43. Read the comment docs.

@itholic
Copy link
Contributor Author

itholic commented Nov 19, 2019

the reason of codecov failure is we skip the doctest related with MiltiIndex since it would be shown different result depends on python version.
add test to tests/test_indexes.py for covering them

@softagram-bot
Copy link

Softagram Impact Report for pull/1059 (head commit: 242ec43)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@HyukjinKwon HyukjinKwon merged commit 0c75471 into databricks:master Nov 22, 2019
@itholic itholic deleted the i_symdiff_fix branch December 2, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants