V2 Materialization flag introduced #844
Open
+243
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-db
requested review from
andrefurlan-db and
rcypher-databricks
as code owners
benc-db
commented
Nov 15, 2024
| @@ -40,8 +93,6 @@ | |||
| {{ get_csv_sql(create_table_sql, sql) }}; | |||
| {% endcall %} | |||
|
|
|||
| {% set target_relation = this.incorporate(type='table') %} | |||
There was a problem hiding this comment.
There's more shared code that I can pull out, but I want to leave the existing materialization largely intact, since the whole reason to use the flag is to lower risk of significant changes. Also, eventually V1 will be deleted. I pulled out target_relation so that I could do the return statement at the top level.
benc-db
commented
Nov 15, 2024
| import pytest | ||
|
|
||
|
|
||
| class MaterializationV2Mixin: |
There was a problem hiding this comment.
Mixin that flips the flag on for test classes that include it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces the V2 Materialization flag (which is primarily going to be used with create table / incremental), and handles the first materialization to be pivoted based on the flag: Seeds. Will be going through each materialization in a separate PR to keep the changes scoped.
Go here to compare the difference in flows: https://github.com/databricks/dbt-databricks/blob/726e6e16d5aec864a37aadb443991d0da265e4b6/docs/seed_flow.md
Seeds are pretty close to ideal already, but had some no op statements that I removed (since we don't have transactions or indexes).
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.