Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When we persist doc, for python lets remember to add a comment #743

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

benc-db
Copy link
Collaborator

@benc-db benc-db commented Jul 24, 2024

Resolves #740

Description

Since python models don't have the capability to write the description with the table writer, when we persist docs, ensure that we persist table-level comments for python.

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

@benc-db benc-db merged commit 806ed26 into main Jul 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model level descriptions aren't being added to Python models
1 participant