Fix capitalization issue #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-db
requested review from
andrefurlan-db and
rcypher-databricks
as code owners
jackyhu-db
reviewed
Jul 24, 2024
| table_schema = lower('{{ relation.schema }}') | ||
| and table_name = lower('{{ relation.identifier }}') | ||
| table_schema = '{{ relation.schema|lower }}' | ||
| and table_name = '{{ relation.identifier|lower }}' |
There was a problem hiding this comment.
what if the table name is configured as case-sensitive
There was a problem hiding this comment.
Can you link to ref? This would be a considerable monkey wrench if so.
There was a problem hiding this comment.
nvm. Just found Databricks table name is always case insenstive.
jackyhu-db
previously approved these changes
Jul 24, 2024
|
Going to merge (after changelog) and if dbt has a better option, will do that as a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incremental tables were potentially not running incrementally if components were specified with capitalization, as in information_schema they are always present in lowercase. Talking to dbt to see if there is a better way to do this, but for now, ensure lower case when used in queries.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.