Cancel python models on Ctrl-C #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-db
requested review from
andrefurlan-db and
rcypher-databricks
as code owners
3 tasks
benc-db
force-pushed
the
fix-python-model-not-cancel
branch
from
9dcf18a
to
c5e3cb1
Compare
|
Hi @benc-db I have tested our scenario, everything runs smoothly, the python model can be canceled! Thank you very much! It's very pleasure to work with you. |
|
Hi @benc-db Thanks for work on this. I still have a question, if we want to use this feature, which version should we use? |
|
|
@benc-db Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #684
Description
When you cancel a running dbt job, running SQL queries are cancelled. This PR extends #690 to propagate the cancel behavior to python models.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.