Support tblproperties (weakly) in python models #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-db
requested review from
andrefurlan-db and
rcypher-databricks
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was an oversight that python models did not support specifying tblproperties in any way. This remedies that, but with a major caveat: because DataframeWriterV1 doesn't support tableProperty (and DataframeWriterV2 does not currently work in the execution env), we can't set tblproperties at table creation. Or more aptly, we might be able to, but it would be a significant rewrite, where we create a table (including specifying column types, ugh) and the insert the data into it as separate steps, so that we could get tblproperties set using the SQL API.
What does that mean? It means that if you want to use tblproperties to anotate your python-generated tables with metadata, you'll now be able to. If, however, you were hoping to use tblproperties on python models to enable some advanced Databricks feature at table creation time, this change will probably not help you.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.