Bug/persist docs/performance #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-db
requested review from
andrefurlan-db and
rcypher-databricks
as code owners
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from #615
Resolves #608
Description
It appears that incremental catalog generation actually takes longer in databricks than generating the catalog all at once. This appears to be partially due to the column comment queries that are required while building the catalog. Running one query to build this all at once is faster once there is more than roughly 5 models. Given how small this break even number, and how infrequently it would be beneficial, it's probably a lot easier to simply turn off incremental catalog generation.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.