Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for various Python models. #189

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Add a test for various Python models. #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d256299
Add a test for various Python models.
ueshin Sep 23, 2022
97c36ba
changelog
ueshin Sep 23, 2022
8127b7f
Merge branch 'main' into python_model_tests
ueshin Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
### Features
- Support python model through run command API, currently supported materializations are table and incremental. ([dbt-labs/dbt-spark#377](https://github.com/dbt-labs/dbt-spark/pull/377), [#126](https://github.com/databricks/dbt-databricks/pull/126))
- Enable Pandas and Pandas-on-Spark DataFrames for dbt python models ([dbt-labs/dbt-spark#469](https://github.com/dbt-labs/dbt-spark/pull/469), [#181](https://github.com/databricks/dbt-databricks/pull/181))
- Implement testing for a test for various Python models ([#189](https://github.com/databricks/dbt-databricks/pull/189))
- Implement testing for `type_boolean` in Databricks ([dbt-labs/dbt-spark#471](https://github.com/dbt-labs/dbt-spark/pull/471), [#188](https://github.com/databricks/dbt-databricks/pull/188))

### Under the hood
Expand Down
6 changes: 6 additions & 0 deletions tests/functional/adapter/test_python_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
BasePythonIncrementalTests,
BasePythonModelTests,
)
from dbt.tests.adapter.python_model.test_spark import BasePySparkTests


@pytest.mark.skip_profile("databricks_sql_endpoint", "databricks_uc_sql_endpoint")
Expand Down Expand Up @@ -64,3 +65,8 @@ def test_changing_schema_with_log_validation(self, project, logs_dir):
assert "On model.test.simple_python_model:" in log
assert "spark.createDataFrame(data, schema=['test1', 'test3'])" in log
assert "Execution status: OK in" in log


@pytest.mark.skip_profile("databricks_sql_endpoint", "databricks_uc_sql_endpoint")
class TestPySparkDatabricks(BasePySparkTests):
pass