Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply "Initial refactoring of incremental materialization" #148

Merged
merged 6 commits into from
Aug 25, 2022

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Aug 3, 2022

Description

Applies "Initial refactoring of incremental materialization" (dbt-labs/dbt-core#5359).

Now it uses adapter.get_incremental_strategy_macro instead of dbt-spark's dbt_spark_get_incremental_sql macro to dispatch the incremental strategy macro. The overwritten dbt_spark_get_incremental_sql macro will not work anymore.

Copy link
Collaborator

@allisonwang-db allisonwang-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

CHANGELOG.md Outdated Show resolved Hide resolved
@ueshin
Copy link
Collaborator Author

ueshin commented Aug 25, 2022

Thanks! merging.

@ueshin ueshin merged commit 74e5ce2 into databricks:main Aug 25, 2022
@ueshin ueshin deleted the incremental_refactor branch August 25, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants