Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply connection retry refactor, add defaults with exponential backoff #137

Merged
merged 3 commits into from
Dec 21, 2022

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Jul 22, 2022

Description

Applies connection retry refactor, add defaults with exponential backoff as per an item from #127.

  • Refactors retry logic to use retry_connection from core.
  • Adds consistent defaults with other adpaters:
    • if connect_retries and connect_timeout are not specified: 1 retry after 1s
    • if connect_retries is specified but connect_timeout is not, it will use exponential backoff

@xg1990
Copy link

xg1990 commented Aug 11, 2022

Thanks a lot! Our team is eagerly waiting for this feature!

@ueshin ueshin marked this pull request as ready for review October 17, 2022 22:19
Copy link
Collaborator

@andrefurlan-db andrefurlan-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems safe as long as we make sure we don't retry on errors that the connector have already retried.

@ueshin
Copy link
Collaborator Author

ueshin commented Dec 21, 2022

Thanks! merging.

@ueshin ueshin merged commit 23725ae into databricks:main Dec 21, 2022
@ueshin ueshin deleted the connection_retries branch December 21, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants