[Internal] Update Jobs GetRun API to support paginated responses for jobs and ForEach tasks #1089
+405
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
gkiko10
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
3 tasks
renaudhartert-db
approved these changes
Nov 8, 2024
|
Test Details: go/deco-tests/11744067074 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Introduces extension for jobs GetRun call that paginates tasks and iterations arrays in the response. This change is necessary to prepare for jobs API 2.2 release that serves paginated response. Pagination is over once the
next_page_tokenis absent from the response. The pagination logic is not exposed to the customer.How is this tested?
Unit test and manual test. I wrote go code that called the new logic and verified that the returned result contained full object when the API was paginated.