Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: skip slash-command-action if comment does not match #52

Merged
merged 1 commit into from
Jan 4, 2022
Merged

ci: skip slash-command-action if comment does not match #52

merged 1 commit into from
Jan 4, 2022

Conversation

YangKian
Copy link
Contributor

@YangKian YangKian commented Jan 4, 2022

Currently, xt0rted/slash-command-action will fail when a non-matching comment is created. Refer to xt0rted/slash-command-action#124. This pr skips the entire job if the comment does not match.

@YangKian
Copy link
Contributor Author

YangKian commented Jan 4, 2022

PTAL~

@YangKian
Copy link
Contributor Author

YangKian commented Jan 4, 2022

seems, it still does not work =-=, I'll convert it to draft and do more check

@YangKian YangKian marked this pull request as draft January 4, 2022 14:56
@drmingdrmer
Copy link
Member

client_reads case is flaky. Re-run-ed it.

@YangKian
Copy link
Contributor Author

YangKian commented Jan 4, 2022

test

@YangKian
Copy link
Contributor Author

YangKian commented Jan 4, 2022

test

@YangKian
Copy link
Contributor Author

YangKian commented Jan 4, 2022

I was stupid, I thought the current pr would take effect immediately after modifying the issue-cmds.yml file, but it seems that it will take effect only after the merge. Sorry this is my first time dealing with GitHub action-related issues. PTAL~

@YangKian YangKian marked this pull request as ready for review January 4, 2022 15:55
@drmingdrmer
Copy link
Member

I was stupid, I thought the current pr would take effect immediately after modifying the issue-cmds.yml file, but it seems that it will take effect only after the merge. Sorry this is my first time dealing with GitHub action-related issues. PTAL~

It is my second or third time too:DDD

drmingdrmer
drmingdrmer approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it :DDD

@mergify mergify bot merged commit 6abc8a6 into databendlabs:main Jan 4, 2022
@YangKian
Copy link
Contributor Author

YangKian commented Jan 4, 2022

Love it :DDD

Thanks for your patience XD

@YangKian YangKian deleted the ci branch January 4, 2022 16:18
@drmingdrmer
Copy link
Member

Love it :DDD

Thanks for your patience XD

And thank you for your hard work that make thing better :DDD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmingdrmer drmingdrmer drmingdrmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YangKian @drmingdrmer