Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): support purge option in copy into table #7518

Merged
merged 6 commits into from
Sep 8, 2022

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Sep 7, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Fixes #7443

@vercel
Copy link

vercel bot commented Sep 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Sep 8, 2022 at 2:07AM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Sep 7, 2022
@sundy-li sundy-li marked this pull request as ready for review September 7, 2022 23:57
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VER should be increased to reflect the what's changed:
https://github.com/datafuselabs/databend/blob/f26bbf31498f6e6a3bcf7095737e8f52bbe76925/src/meta/proto-conv/src/util.rs#L17

This can just be merged. Let me fire another to do this.
The VER should be more semantic to users.

Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add PURGE option to COPY command
4 participants