Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): make memory engine as non-local table #16955

Merged
merged 7 commits into from
Nov 28, 2024
Merged

fix(query): make memory engine as non-local table #16955

merged 7 commits into from
Nov 28, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Nov 27, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix(query): make memory engine as non-local table

fixes #16941

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 27, 2024
@sundy-li sundy-li changed the title fix(query): disallow insert into local table in cluster mode fix(query): make memory engine as non-local table Nov 27, 2024
@sundy-li sundy-li added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@sundy-li sundy-li added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@sundy-li sundy-li added this pull request to the merge queue Nov 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 28, 2024
@xudong963 xudong963 added this pull request to the merge queue Nov 28, 2024
Merged via the queue into databendlabs:main with commit 06c4ab6 Nov 28, 2024
72 checks passed
@xudong963 xudong963 deleted the distributed-insert-local branch November 28, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xudong963 xudong963 xudong963 left review comments

@zhang2014 zhang2014 zhang2014 left review comments

@BohuTANG BohuTANG BohuTANG left review comments

@SkyFan2002 SkyFan2002 SkyFan2002 approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: create table xxx engine = memory as xxx lost columns under cluster
5 participants
@sundy-li @BohuTANG @zhang2014 @xudong963 @SkyFan2002