Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support USE CATALOG syntax and current_catalog() function #16926

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

flashmouse
Copy link

@flashmouse flashmouse commented Nov 24, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Nov 24, 2024
@flashmouse
Copy link
Author

I observe that use_database statement is prior to use_catalog unless I quote #ident(catalog)

use catalog abc  // parse to UseDatabase{"catalog "} which is unexpected
use catalog `abc` //  parse to UseCatalog{"abc"} correctly

@b41sh b41sh self-requested a review November 24, 2024 15:23
@flashmouse
Copy link
Author

@b41sh please help me check if it is suitable now

@b41sh
Copy link
Member

b41sh commented Nov 27, 2024

Hi @flashmouse Seems almost OK for me. Better to add some test cases in tests/suites/3_stateful_iceberg/00_rest/00_0000_create_and_show.sh and tests/suites/3_stateful_iceberg/00_rest/00_0000_create_and_show.result

@flashmouse
Copy link
Author

Hi @flashmouse Is this PR ready to review? Seems almost OK for me. Better to add some test cases in tests/suites/3_stateful_iceberg/00_rest/00_0000_create_and_show.sh and tests/suites/3_stateful_iceberg/00_rest/00_0000_create_and_show.result

I would mark this as ready to review after add test as you advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support USE CATALOG syntax and current_catalog() function
2 participants