Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add snapshot location cache for attached table #16795

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Nov 8, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

To avoid redundant extraction of snapshot location from hint file, a snapshot location cache is added at the table instance level for tables that are attached to another table.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - use existing tests

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

To avoid redundant extraction of snapshot location from hint file, a
snapshot location cache is added at the table instance level for tables
that are attached to another table.
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Nov 8, 2024
@dantengsky dantengsky marked this pull request as ready for review November 8, 2024 06:25
@dantengsky dantengsky added this pull request to the merge queue Nov 8, 2024
Merged via the queue into databendlabs:main with commit 21f3bab Nov 8, 2024
80 checks passed
@dantengsky dantengsky deleted the chore-add-location-cache branch November 8, 2024 07:11
dantengsky added a commit to dantengsky/fuse-query that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants