-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add extra bracket for and
and or
to make explain clear
#16494
Conversation
Some tests still need to fix the format. |
What bug does this fix? maybe add a test. |
and
and or
to make explain clear
In fact, there is no bug, By adding |
Hi @xudong963 statement ok
DROP TASK IF EXISTS mytaskchild2
statement ok
CREATE TASK mytaskchild2
WAREHOUSE = 'mywh'
AFTER 'mytaskroot'
WHEN ((SYSTEM$STREAM_HAS_DATA('stream1') AND SYSTEM$STREAM_HAS_DATA('stream2')) OR (SYSTEM$STREAM_HAS_DATA('stream3') AND SYSTEM$STREAM_HAS_DATA('stream4'))) AND SYSTEM$STREAM_HAS_DATA('stream5')
AS SELECT 1;
query SSSS
select name, warehouse, schedule, definition, condition_text, after from system.tasks where name = 'mytaskchild2'
----
mytaskchild2 mywh NULL SELECT 1 ((SYSTEM$STREAM_HAS_DATA('stream1') AND SYSTEM$STREAM_HAS_DATA('stream2')) OR (SYSTEM$STREAM_HAS_DATA('stream3') AND SYSTEM$STREAM_HAS_DATA('stream4'))) AND SYSTEM$STREAM_HAS_DATA('stream5') mytaskroot
|
…tabendlabs#16494) * fix: add extra bracket for and or * add task test
) * feat: implement `is_not_null` selectivity based on null count in stats (#16730) * feat: implement is_not_null selectivity based on null count in stats * fix test * chore(planner): improve cardinality estimation (#16938) * chore(planner): improve cardinality estimation * chore(planner): improve histogram cardinality estimation * chore(planner): improve join cardinality * chore(test): update sqllogictest * chore(test): update sqllogictest * chore(code): refine code * chore(test): update sqllogictest * chore(test): test ci tpch * chore(code): fix typos * chore(test): remove accurate_his test * chore(test): fix sqllogictest * chore(query): fix sub overflow * chore(planner): refine scan histogram * chore(test): update sqllogictest * chore(test): update sqllogictest * ci: fix flaky test (#16945) * ci: fix flaky test #16935 * ci: update error format of Bendsql. * feat: filter null value before join (#16722) * feat: filter null value before join * fix lint * add annotations and process possible crash * dedup filters and fix tests (also need to fix native explain test) * fix test * support semi join * fix test for semi join * adjust threshold and enable only distribution * chore(planner): resolve conflicts * fix(query): support subquery in pivot (#16631) * fix(query): support subquery in pivot * add pivot and unpivot sqllogictests, fix unit-test * code format * chore(code): resolve conflicts * chore(test): update sqllogictest * chore(test): update sqllogictest * Revert "ci: fix flaky test (#16945)" This reverts commit efcbac3. * chore: add extra bracket for `and` and `or` to make explain clear (#16494) * fix: add extra bracket for and or * add task test * chore(test): update sqllogictest * Revert "Revert "ci: fix flaky test (#16945)"" This reverts commit 49ea151. * fix(query): forbid explain explain statement (#16654) fix(query): forbiden explain explain statement * fix(ci): flaky test (#16933) * flaky test * fix * fix test * chore(code): resolve conflicts * chore(test): update test --------- Co-authored-by: xudong.w <[email protected]> Co-authored-by: Jk Xu <[email protected]> Co-authored-by: Yang Xiufeng <[email protected]> Co-authored-by: Liu Zhenlong <[email protected]> Co-authored-by: Dousir9 <[email protected]> Co-authored-by: TCeason <[email protected]> Co-authored-by: zhya <[email protected]>
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Tests
Type of change
This change is