Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: distributed copy into table from query #11943

Merged

Conversation

JackTan25
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

distain
Summary about this PR
finish distributed copy into table from query

@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Visit Preview Jul 14, 2023 1:50pm

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jul 3, 2023
@JackTan25
Copy link
Contributor Author

askbend:summary

@JackTan25 JackTan25 force-pushed the distributed_copy_into_table_for_query branch from 592d7b5 to c6c1910 Compare July 3, 2023 08:12
@JackTan25 JackTan25 force-pushed the distributed_copy_into_table_for_query branch from c6c1910 to 7110c54 Compare July 3, 2023 08:16
@JackTan25
Copy link
Contributor Author

askbend:summary

@JackTan25 JackTan25 requested review from youngsofun, RinChanNOWWW and leiysky and removed request for RinChanNOWWW July 3, 2023 11:07
@BohuTANG
Copy link
Member

BohuTANG commented Jul 3, 2023

askbend:summary

1 similar comment
@JackTan25
Copy link
Contributor Author

askbend:summary

RinChanNOWWW
RinChanNOWWW previously approved these changes Jul 4, 2023
@BohuTANG BohuTANG requested a review from dantengsky July 4, 2023 09:34
@JackTan25
Copy link
Contributor Author

we should enable distributed copy after long run test. make sure the correctness

@JackTan25 JackTan25 force-pushed the distributed_copy_into_table_for_query branch from fa0d942 to 70a45fd Compare July 4, 2023 10:34
@JackTan25 JackTan25 added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Jul 14, 2023
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-11943-b76e97b

note: this image tag is only available for internal use,
please check the internal doc for more details.

1 similar comment
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-11943-b76e97b

note: this image tag is only available for internal use,
please check the internal doc for more details.

Copy link
Member

@dantengsky dantengsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

suggested a tiny code refactoring, hope I get it correct.

@BohuTANG BohuTANG added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Jul 14, 2023
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-11943-60402f3

note: this image tag is only available for internal use,
please check the internal doc for more details.

@JackTan25 JackTan25 merged commit f3cbcd7 into databendlabs:main Jul 14, 2023
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
* finish copy from query

* fix typo

* add purge

* fix result

* fix typo

* add tests

* remove useless comments

* fix conflict

* fix clippy

* fix clippy

* add more tests

* add more tests

* add query T

* fix test

* update

* update error code

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cloud Build docker image for cloud test pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants