theme is missing font fa-brands-400.woff2 #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndy40
changed the title
fa-brands-400.woff2
ndy40
changed the title
fa-brands-400.woff2
|
Hey @ndy40, thanks for pointing me at this problem. I did remove all the font files which are not "woff" on purpose, Thanks for your effort to even create a PR, but because of the upcoming update of FontAwesome anyway, your PR is not needed. Regards, Ben |
|
When I'm finished with the version update of FontAwesome I'll create one more comment here. 👍 |
|
The release is now available and you either download the stable release or clone the repository. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The theme is missing the font
static/webfonts/fa-brands-400.woff2.This sometimes causes the page not to display correctly on some phones with certain browser.
Had a friend view a Hugo site I was trying out and this got flagged. Not a problem in normal browsers.