Switch to using a fork of bitarray that distributes binary wheels. #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change means users no longer require a C compiler to install clkhash.
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
=======================================
Coverage 93.81% 93.81%
=======================================
Files 17 17
Lines 1359 1359
=======================================
Hits 1275 1275
Misses 84 84 |
gusmith
approved these changes
Oct 30, 2019
There was a problem hiding this comment.
A tiny tiny change would be good in the changelog, but it may also be good to create a new issue to track the fact that we are using a fork.
Also, the issue #153 is not pointing directly to bitarray installation, but only to its requirement, but I'm assuming it can be closed by this PR as the problem was not directly using an extra library, but the fact that its installation was complicated.
CHANGELOG.md
Outdated
| - Migrate to Azure DevOps for CI testing. | ||
| - Synthetic data generation using distributions. | ||
| - Switch to using a fork of `bitarray` that distributes binary wheels so installing clkhash doesn't require a compiler. |
There was a problem hiding this comment.
May be good practice to start adding the PR number to the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change means users no longer require a C compiler to install clkhash.
While waiting to see whether the upstream
bitarraylibrary will distribute binary wheels (in ilanschnell/bitarray#76) this PR switches to my fork which publishes binary wheels for each platform from a CI. See also issue #153https://pypi.org/project/bitarray-hardbyte/
🤡