Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLUGIN-1783] Adding Retry with dev.failsafe #35

Merged
merged 1 commit into from
May 13, 2024
Merged

[PLUGIN-1783] Adding Retry with dev.failsafe #35

merged 1 commit into from
May 13, 2024

Conversation

psainics
Copy link
Contributor

@psainics psainics commented May 1, 2024 •
edited
Loading

Adding Retry with dev.failsafe

Jira : PLUGIN-1783

Description

Adding retry on calls to the service, and adding new (hidden) ui fields to let user configure the retry mechanism.

UI Field

  • Modified SuccessFactors-batchsource.json
    • Adding hidden fields to let user configure the retry mechanism.
      • retryMultiplier
      • maxRetryCount
      • maxRetryDuration
      • initialRetryDuration

Docs

  • No Changes made to docs.
  • Fields are hidden.

Code change

  • Modified SuccessFactorsConnector.java
  • Modified SuccessFactorsPluginConfig.java
  • Modified SuccessFactorsService.java
  • Modified SuccessFactorsTransporter.java

Unit Tests

  • Modified SuccessFactorsPluginConfigTest.java
  • Modified SuccessFactorsInputFormatTest.java
  • Modified SuccessFactorsSchemaGeneratorTest.java
  • Modified SuccessFactorsUrlContainerTest.java

image
image

@psainics psainics added the build label May 1, 2024
@psainics psainics force-pushed the feat/retry-dev-failsafe branch from 51222cd to 4489e51 Compare May 6, 2024 01:44
@psainics psainics force-pushed the feat/retry-dev-failsafe branch from 4489e51 to 40c9834 Compare May 6, 2024 02:22
@psainics psainics merged commit 02d8aa8 into data-integrations:develop May 13, 2024
5 checks passed
@psainics psainics mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsankit-google itsankit-google itsankit-google approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psainics @itsankit-google